Food's forum themes - v8 pre

Thanks both for the access and for the screens. I should be able to position them correctly by using buttons I can see, so v7b should feature them.

About the priorities thing, I'll reword it with the next update, I wasn't trying to imply you don't care about themes, just that you and the other admins are working on more important core stuff

suchbalance wrote:Well done Food, really great job. I'm a bit ashamed to admit that I actually got used to the white theme (even after disliking it initially) and prefer it to yours in terms of readability and lines basically, but you really did a great service to all the users who prefer the darker tones.

That's totally cool man, no need to feel ashamed :lol:

v7b will most probably also feature a light theme that is not as white as the default one and lower contrast. It still needs some tinkering but it's pretty much ready (I think), so maybe you'll like that. And if you don't it's not a problem.

Marco wrote:My only real criticism so far is that some parts are lacking some sort of separation

Very true, I removed every border (since 95% of them were useless) with a global selector, I still need to re-add some of them in. Firefox is especially finicky about it. The missing border for nested content on firefox is an excellent example I have the following css rules in the code

Code: Select all

blockquote,
code,
div.codebox,
div.detail-spoiler div.hidden,
div.spoilwrapper {
    border:             1px solid $border_color !important;
}

div.content > blockquote,
div.codebox > code,
div.content > div.codebox,
div.content > div.detail-spoiler div.hidden,
div.content > div.spoilwrapper {
    border:             0px                     !important;
}

Those work as expected on Cr (every blockquote, code etc has a border, except those elements that are direct children of a div.content -- or div.codebox for the code tag -- this way nested content has a border, while not nested content doesn't) and looks like this.
The same exact code on firefox produces this.

I already fixed several similar things on firefox, I really don't know why it behaves this way.

maybe you can try to use more specific selectors

the ideal scenario (and the way it's done, for the most part) is to have all color related css in a separate file (colours.css), so this file becomes pretty much the core css file to change in order to add new themes (other css may require changes depending on theme, for example not all buttons are handled in that file). But as I previously mentioned, css files arent completely organized yet and there is some inline css that needs to be moved or some temporal CSS in stylesheets.css. Also there are some css files that handle specific sections (for example guides forum, or badges css) which should be eventually integrated to the standard css files (common.css, content.css, colours.css)

Well, I do something very similar for the theme, but since I used SASS which lets me define variables, I have a colors.scss file which only contains the variables which define the colors that are used throughout the project (you can see the file here, the whole project is here).

As you can see a preliminary "assassin light" theme is already defined in that file and it's pretty much working already, so that shouldn't be a problem. I'll also organize the files better in different folders in the future.

Ooo so there will be more than one *stylish* theme? Woohoo! (I've been hoping for something between black and white)

V7b is out, it fixes all known v7 bugs (well, to be fair some firefox buttons are still 2px taller than chrome's), and it now comes in two styles dubbed assassin dark and assassin light.

Please note that the light theme should be considered "beta", meaning it wasn't tested as much so colors may be a bit off.

Also, please report any missing borders or similar stuff on firefox, it tends to have that problem it seems.

many things I like from light theme (except posts background which is imho too dark). buttons and such look really nice, will consider making it like that in the default theme too.

btw. personal reocmmendation, don't overuse the !important parameter - things get nasty with it. Also I think you probably won't need it at all when we integrate it with the forums

Yep, I use !important on everything because of the way stylish and userstyles behave. Basically, depending on whether users use firefox or chrome (or stylish or greasemonkey or tampermonkey) userstyles are applied in different ways / at different times. On some browsers and with some extensions if an userstyle selector has the same specificity of the website selector the userstyle one will be applied. On some other browsers and /or with different extensions the website one will be applied.

Of course I could just be more specific with the userstyle selectors, but that's not always possible and it may sometimes cause some little issues with overqualified selectors, so I just threw !important on everything. I think it's pretty standard as far as userstyles go.

Double post ftw! v7c is out, changelog is in first post as always.

Triple post because of version bump. v7e is out.

Been using mxl theme assassin.

I just notice that I cant see horizontal line like below:

I think it should be white like post/signature spliter.

I can see it if I turn of the theme though.